Update version in Helm values #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
unflxw
force-pushed
the
update-version-helm-values
branch
from
58ce2a1 to
7469ba0
Compare
tombruijn
approved these changes
Jul 29, 2025
script/write_version
Outdated
Comment on lines
16
to
18
| File.write( | ||
| "charts/appsignal-kubernetes/values.yaml", | ||
| File.read("charts/appsignal-kubernetes/values.yaml").sub(/tag: .*$/, %(tag: "#{VERSION}"))) |
There was a problem hiding this comment.
How many places do we need to update the version number? 😅
There was a problem hiding this comment.
Yeah, no, you're right, this shouldn't be necessary. We should use appVersion (from Chart.yaml) and not hardcode any values in values.yaml.
Update the default version of the image that is to be deployed by the Helm chart.
Stop breaking the Helm chart all the time by verifying that it passes the Helm linter, that templates can be built for it with and without `--set kubectl=true`, and that changes to it have been committed.
unflxw
force-pushed
the
update-version-helm-values
branch
from
7469ba0 to
8bac8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the default version of the image that is to be deployed by the Helm chart.